Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shrink offerbook chat when offer list and user profile are open at the same time #2868

Open
suddenwhipvapor opened this issue Sep 29, 2024 · 3 comments
Assignees
Milestone

Comments

@suddenwhipvapor
Copy link
Contributor

If there is the offerlist column visible, and you click on a user's icon to see their details, this happens:
image
I am on a fullhd screen.
Since the offerlist is already gauged to its ideal size, the only remaining option is to make the offerbook chat less wide, at least until any of the two other column is closed.

@axpoems
Copy link
Contributor

axpoems commented Sep 29, 2024

Yes, this is an issue.
Two things are needed to improve it:

  1. The use of a a split pane or similar so that we can slide and make the chat window smaller (offers now are pretty small so there's room to shrink that window). Same concept can apply to the offerlist.
  2. Change the interaction of how user details appears. Perhaps an additional column is not the best.

@axpoems axpoems self-assigned this Sep 29, 2024
@suddenwhipvapor
Copy link
Contributor Author

On one hand, 2 is a lateral approach I appreciate, on the other the column for details is a consistent factor across the application interface and it's not a bad idea to keep it as is. No strong feelings about either.

@suddenwhipvapor
Copy link
Contributor Author

Lateal-lateral approach: make the user details column a hovering component, that will disappear out of the side of the screen after a certain kind of interaction.
But I guess that for consistency, it should always be presented this way wherever in the application, and maybe it's a coding nightmare in javafx. I know it would be somewhat trivial in css (+javascript).

@axpoems axpoems added this to the 2.1.2 milestone Sep 29, 2024
@HenrikJannsen HenrikJannsen modified the milestones: 2.1.2, 2.1.3 Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants