Cycle 1

[devinbileck]

Summary

This compensation request covers work delivered since the previous voting period (for March) up until the end of the DAO cycle 1 proposal phase, between 2019-04-01 and 2019-05-09.

Since the BSQ market is still new and undergoing price discovery, it still assumes 1 BSQ == 1 USD.

• BSQ requested: 5300
• DAO proposal transaction: https://explorer.bisq.network/tx.html?tx=1fbc48fc1052287dcd33da555184a3e095bd089244b2375cf1a4a3afe67c2367

Contributions delivered

• Transferring ownership of several nodes. In order to further decentralize operation of various network nodes, I have setup new instances and taken ownership of the following nodes from @ManfredKarrer. [600 BSQ]

  • Pricenode 44mgyoe2b6oqiytt.onion (Reflect pricenode operator change in ProvidersRepository bisq#2769)
  • Relaynode jtboonrvwmq7frkj.onion (Update mobile notification relay node DEV_URL IP address bisq#2770)
  • Seednode 3f3cu2yw7u457ztq.onion (Reflect mainnet seednode operator change bisq#2803)

  Note: Compensation for setup of these nodes is valued at 200 BSQ each as per the following:

  • https://docs.bisq.network/exchange/howto/run-price-relay-node.html#payment
  • https://docs.bisq.network/exchange/howto/run-seednode.html#payment

• Manual testing. I was mostly focused on exploratory style testing DAO related functionality prior to the DAO launch. I did not follow the pre-defined test cases within Testpad so much since they were already covered and I wanted to explore untested aspects and edge case scenarios. I mainly encountered/entered UI issues or improvements, but found a couple significant issues (see below). [3000 BSQ]

  • Update prompt not shown on Windows
  • Incorrect voting cycle number shown after phases were changed
  • No indication of error when vote reveal published out of phase
  • Confusing error message when attempting to publish a vote that would create a BSQ change output less than the dust limit
  • Results of param change proposal for a previous cycle shows current value of parameter rather than previous value
  • Provide feedback sooner when requested issuance of all compensation requests exceeds the limit
  • Error is encountered when taking offer using BSQ as fees with insufficient balance
  • There is no UI validation for max value when setting stake for voting
  • When restoring wallet from seed, vote weight from earned BSQ is reset to 0
  • Show prompt when closing the app if you have voted but not published your vote
  • Indicate when in the voting phase or when vote results are available
  • Inconsistent current value is displayed when submitting param change proposal
  • Add next/previous buttons to proposal details popup
  • Strip the exception type when showing a checkArgument message to the user
  • Translate checkArgument messages
  • Issues submitting proposal with less than 7.46 BSQ available
  • Client becomes stuck synchronizing DAO when generating multiple blocks simultaneously in regtest

• Bug bounties.

  • Issues submitting proposal with less than 7.46 BSQ available bisq#2613 (comment): The scenario detailed within this issue would have caused a submitted proposal transaction to become invalid and the user would have lost their proposal fee. [1000 BSQ]

• Implemented misc bug fixes. To desktop client. [400 BSQ]

  • Fix incorrect transaction size shown for bonding
  • Update insufficient BTC warning for issuance proposals
  • Fix incorrect required BSQ amount in warning text
  • Fix max available stake for voting showing negative

• Reviewed PRs. [100 BSQ]

  • Add UTF8 for getBytes calls
  • Add missing check for mandatory bsq output

BSQ amount requested: 5100

Contributions in progress

• Expanding manual test coverage. I have been creating test cases in our new testing tool https://bisq.ontestpad.com. I have a basic structure implemented with test scenarios for various components of the Bisq desktop application. However, some scenarios are just placeholders and require additional details added, and there are several components that will need scenarios to be implemented. Once the majority of the scenarios are implemented and the placeholders completed, I will request compensation for this.

Roles performed

• Bitcoin node operator: Bitcoin Node Operator roles#67 (comment) [50 BSQ]
• Pricenode operator: Pricenode Operator roles#14 (comment) [50 BSQ]
• Relay operator for mobile notifications: Relay operator for mobile notifications roles#82 (comment) [50 BSQ]
• Seed node operator: Seednode Operator roles#15 (comment) [50 BSQ]

BSQ amount requested: 200

Notes to self

Details

• My contributions were determined by reviewing the results of this GitHub search query:
  https://github.com/bisq-network/bisq/pulls?q=is%3Apr+is%3Amerged+author%3Adevinbileck+updated%3A2019-04-01..2019-05-09

• My PR reviews this month were determined by reviewing the results of this GitHub search query:
  https://github.com/bisq-network/bisq/pulls?utf8=%E2%9C%93&q=is%3Apr+reviewed-by%3Adevinbileck+updated%3A2019-04-01..2019-05-09+sort%3Aupdated-desc

• My issues discovered/entered were determined by reviewing the results of this GitHub search query:
  https://github.com/bisq-network/bisq/issues?utf8=%E2%9C%93&q=is%3Aissue+author%3Adevinbileck+created%3A2019-04-01..2019-05-09