Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Cycle 11 #499

Closed
ripcurlx opened this issue Feb 17, 2020 · 6 comments
Closed

For Cycle 11 #499

ripcurlx opened this issue Feb 17, 2020 · 6 comments
Assignees
Labels
team:admin https://bisq.wiki/Admin_Team team:dev https://bisq.wiki/Dev_Team team:support https://bisq.wiki/Support_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Milestone

Comments

@ripcurlx
Copy link
Contributor

ripcurlx commented Feb 17, 2020

Summary

  • BSQ requested:5795 (3825 USD @ 0.66 USD/BSQ)

This is a compensation request for contributions delivered from last cycle until now (Mar 16). I calculated the amount based on the new three months average of 0.66 USD for 1 BSQ mentioned in #501.

Proposal transaction ID: dcc894597fb9fdb589c1ba78a3f7b413084795e216540024a51aed3e3c78b054

Contributions delivered

Reviews

Reviewed PRs:

View all reviewed PRs (27)

My PR reviews this month were created by reviewing the results of this GitHub Issues search query:
is:pr reviewed-by:ripcurlx updated:2020-02-14..2020-03-16 sort:updated-desc

Following PRs Review efforts are so small to track them separately:

Total USD amount for this remaining PRs: 400

USD amount requested: 888

Development

I was working mainly on the v1.2.8 release and following PRs were merged to master.

View all merged PRs

My merged PRs this month were created by reviewing the results of this GitHub Issues search query:
is:pr author:ripcurlx is:merged merged:2020-02-14..2020-03-16 sort:updated-desc

Following PRs are minor or not within our priorities:

USD amount requested: 340

Following PRs are covered by other role efforts already, are minor or not a prioritiy:

Testing

Test reporting for v1.2.8 release testing can be found here: https://bisq.ontestpad.com/project/1/folder/f56/report/?auth=28145f4fcbb5bc8d90372112bb3f00a9

Besides that I did additional smoke testing on Mainnet.

USD amount requested: 300 USD

Release

To improve transparency I'll add the release efforts now separately and not combined with the Bisq Desktop Maintainer role anymore. Documentation of the release process can be found here.

As the last three releases always required a hotfix shortly after based on specific OS setups we'll need to change release testing to include as many contributors as possible to at least start and smoke test a release candidate. I'll announce more details shortly after our next v1.2.9 hotfix release.

USD amount requested: 720 USD

Support

Monitoring the support channel during my L2 times and am investigation atm one issue where funds are still locked up although trades were completed successfully.
Helping out L1 support whenever needed.

Support cases:

USD amount requested: 422 USD

Contributions in progress

I'm focusing right now on v1.2.9 and continue to get the PR workflow more streamlined.
Besides that I'm working on account signing improvements.

All efforts for my role as dev team lead (roughly occupied ~60% of my time) won't be put up for compensation until it is proven to have the success we are looking for.

Roles performed

USD amount requested for all these roles (see detailed amount for each role): 1155 USD

The following are roles where I play a secondary role, and do not (necessarily) do monthly reports:

@ripcurlx ripcurlx changed the title [WIP] For Cycle 11 For Cycle 11 Mar 16, 2020
@cbeams cbeams self-assigned this Mar 16, 2020
@cbeams
Copy link
Member

cbeams commented Mar 16, 2020

Monitoring the support channel during my L2 times

The nature of L2 work should be push, not pull, as in L1 agents should ping you when help is needed; it shouldn't be required for you to monitor the support channel. Of course it's fine if you wish to do this, but I just want to check: how much of the 422 USD being requested for L2 work is because of active monitoring vs actually addressing L2 issues? I assume it's mostly the latter, but I was a bit surprised by the number being that high. Were these just difficult / time-consuming issues?

Other than this question, the request looks good to me.

@cbeams
Copy link
Member

cbeams commented Mar 17, 2020

Since we're getting close to the deadline, I'd say submit your DAO proposal in any case, with my approval on this. Would be good to have the answer to the above, but we don't need to hold this up on it.

@sqrrm
Copy link
Member

sqrrm commented Mar 17, 2020

I can't speak for @ripcurlx's workload from L2 support issues but for me it's been very time consuming. It's hard to differentiate though since they're genuine bugs so some of that time will be documented as dev effort and some in the support section. I have found that L1 support handles most cases that can be handled without a dev rather well. The problem is that we still have too many bugs.

@ripcurlx
Copy link
Contributor Author

I just want to check: how much of the 422 USD being requested for L2 work is because of active monitoring vs actually addressing L2 issues? I assume it's mostly the latter, but I was a bit surprised by the number being that high. Were these just difficult / time-consuming issues?

This was mainly caused by the locked up funds issue, which made lots of code reading and back and forth communication between the affected user necessary.

@ripcurlx
Copy link
Contributor Author

Proposal transaction ID: dcc894597fb9fdb589c1ba78a3f7b413084795e216540024a51aed3e3c78b054

@MwithM MwithM added the was:accepted Indicates that a compensation request was accepted by DAO voting label Mar 27, 2020
@MwithM
Copy link
Contributor

MwithM commented Mar 27, 2020

closing as accepted

@MwithM MwithM closed this as completed Mar 27, 2020
@cbeams cbeams added this to the Cycle 11 milestone Apr 7, 2020
@cbeams cbeams added team:admin https://bisq.wiki/Admin_Team team:dev https://bisq.wiki/Dev_Team team:support https://bisq.wiki/Support_Team labels Apr 7, 2020
@cbeams cbeams mentioned this issue Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team:admin https://bisq.wiki/Admin_Team team:dev https://bisq.wiki/Dev_Team team:support https://bisq.wiki/Support_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Projects
Archived in project
Development

No branches or pull requests

4 participants