Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Cycle 19 #721

Closed
sqrrm opened this issue Nov 26, 2020 · 6 comments
Closed

For Cycle 19 #721

sqrrm opened this issue Nov 26, 2020 · 6 comments
Assignees
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team team:ops https://bisq.wiki/Ops_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Milestone

Comments

@sqrrm
Copy link
Member

sqrrm commented Nov 26, 2020

Summary

Specify the total amount of BSQ you are requesting, along with the USD total and BSQ/USD rate (don't include the brackets!):

  • BSQ requested: 2910
  • USD requested: 1950
  • BSQ rate: 0.67 USD per BSQ
  • Previous compensation request (if applicable): For Cycle 18 #693

Contributions delivered

Add contributions you have delivered and roles you have performed here as new rows in the table below. Role line-items should include an asterisk (*) in the team column.

Title Team USD Link Notes
Signed account cleanup dev 180 bisq-network/bisq#4744
bisq-network/bisq#4694 Small reviews
bisq-network/bisq#4695
bisq-network/bisq#4689
bisq-network/bisq#4681
bisq-network/bisq#4732
bisq-network/bisq#4726
bisq-network/bisq#4745
bisq-network/bisq#4746
bisq-network/bisq#4750
bisq-network/bisq#4769
bisq-network/bisq#4784
bisq-network/bisq#4792
bisq-network/bisq#4838
bisq-network/bisq#4846
dev 300 bisq-network/bisq#4822 Total for items above
bisq-network/bisq#4692 API reviews
bisq-network/bisq#4696
bisq-network/bisq#4697
bisq-network/bisq#4699
bisq-network/bisq#4700
bisq-network/bisq#4701
bisq-network/bisq#4703
bisq-network/bisq#4704
bisq-network/bisq#4705
bisq-network/bisq#4709
bisq-network/bisq#4711
bisq-network/bisq#4712
bisq-network/bisq#4713
bisq-network/bisq#4714
bisq-network/bisq#4716
bisq-network/bisq#4722
bisq-network/bisq#4723
bisq-network/bisq#4724
bisq-network/bisq#4725
bisq-network/bisq#4731
bisq-network/bisq#4793
bisq-network/bisq#4794
bisq-network/bisq#4795
bisq-network/bisq#4796
bisq-network/bisq#4797
bisq-network/bisq#4798
dev 450 bisq-network/bisq#4799 Total for items above
Inventory dev 120 bisq-network/bisq#4680, bisq-network/bisq#4688
Persistence dev 120 bisq-network/bisq#4628, bisq-network/bisq#4804
Blackmail fix dev 100 bisq-network/bisq#4789
Bisq desktop maintainer dev* 500 bisq-network/roles#63 (comment)
Bitcoin node maintainer dev* 50 bisq-network/roles#66 (comment)
Bitcoin node operator ops* 100 bisq-network/roles#67 (comment)
Tor relay operator ops* 30 bisq-network/roles#72 (comment)
Explorer operator ops* 0 I will not operate an explorer going forward

Contributions in progress

Provide links to work you're involved with that is still in progress. This section is optional (the linter ignores it), and is for your own benefit in keeping track of what you're doing and keeping other contributors up to date with the same.

Title Team USD Link Notes
Atomic BSQ trading dev ~8000 bisq-network/bisq#4414 Working on making BSQ trades atomic. One transaction to send BTC to buyer and BSQ to seller, removing the need for mediators and refund agent. After the changes to trade protocol I had some discussions with the chimp and I now plan on changing the whole take offer procedure as it's currently not possible to avoid the deposit requirement. That would skip many steps, simplify the atomic process and avoid further unnecessary entanglement. BSQ used in atomic txs will not be possible to spend until confirmed since the source is mixed.
@ghost ghost added the parsed:invalid https://bisq.wiki/Compensation#Ensure_your_request_is_valid label Nov 26, 2020
@ghost
Copy link

ghost commented Nov 26, 2020

Info

Read BSQ amount from summary: 0
Read USD amount from summary: 0
Read BSQ rate from summary: 0.67
Parsed lineitem: {"team":"dev","amount":300}
Parsed lineitem: {"team":"dev","amount":450}
Parsed lineitem: {"team":"dev","amount":250}
Parsed lineitem: {"team":"dev","amount":650}
Parsed lineitem: {"team":"dev","amount":120}
Parsed lineitem: {"team":"dev","amount":250}
Parsed lineitem: {"team":"dev","amount":360}
Parsed lineitem: {"team":"dev","amount":200}
Parsed lineitem: {"team":"dev","amount":100}
Parsed lineitem: {"team":"dev","amount":50}
Parsed lineitem: {"team":"ops","amount":100}
Parsed lineitem: {"team":"ops","amount":30}
Parsed lineitem: {"team":"ops","amount":100}

Errors

ERROR: Total USD does not match the sum of line items:

  • Summary total: 0.00 USD
  • Calculated total: 2960.00 USD

@ghost ghost added team:dev https://bisq.wiki/Dev_Team team:ops https://bisq.wiki/Ops_Team labels Nov 26, 2020
@sqrrm sqrrm changed the title For Cycle 19 [WIP] For Cycle 19 Nov 26, 2020
@sqrrm sqrrm changed the title [WIP] For Cycle 19 For Cycle 19 Nov 26, 2020
@ghost ghost added parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid and removed parsed:invalid https://bisq.wiki/Compensation#Ensure_your_request_is_valid labels Nov 26, 2020
@MwithM MwithM added this to the Cycle 19 milestone Nov 26, 2020
@wiz
Copy link
Member

wiz commented Nov 30, 2020

Approved for ops

@wiz wiz removed their assignment Nov 30, 2020
@ripcurlx
Copy link
Contributor

As team lead I approve this request. Please submit your DAO proposal and paste the transaction ID here as a comment when complete, thanks.

@sqrrm
Copy link
Member Author

sqrrm commented Dec 1, 2020

Tx: 6e46ac8866c28cd81c40b5a9d630558bdeeba0fa14aca8902d5effb16804d347

@MwithM MwithM added the was:accepted Indicates that a compensation request was accepted by DAO voting label Dec 9, 2020
@ghost
Copy link

ghost commented Dec 9, 2020

Issuance by Team:

team amount BSQ amount USD
dev 2716.00 1820.00
ops 194.00 130.00

Total Issuance: 2910.00 BSQ (equivalent to: 1950.00 USD)

@MwithM
Copy link
Contributor

MwithM commented Dec 9, 2020

Closed as accepted.

@MwithM MwithM closed this as completed Dec 9, 2020
@sqrrm sqrrm mentioned this issue Dec 28, 2020
@sqrrm sqrrm mentioned this issue Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team team:ops https://bisq.wiki/Ops_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Projects
Archived in project
Development

No branches or pull requests

4 participants