Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detection of too similar annotations for non bounding boxes does not work well enough #157

Open
johagge opened this issue Nov 12, 2020 · 1 comment

Comments

@johagge
Copy link
Contributor

johagge commented Nov 12, 2020

Is your feature request related to a problem? Please describe.

When using bounding boxes to annotate something and a too similar annotation already exists, the user is informed and the annotation is discarded.
If the user does the same with two polygons instead of a bounding box, no warning is given and the annotation is added.

Describe the solution you'd like

I would expect the same behavior for bounding boxes and polygons (and other annotation types).

@johagge johagge changed the title Detect too similar annoations for non bounding boxes Detect too similar annotations for non bounding boxes Nov 12, 2020
@timonegk
Copy link
Member

timonegk commented Dec 6, 2020

This feature currently exists but it does not seem to work well enough for most labels because the new polygon points have to match the existing very closely. The current solution could be replaced by calculating the center point of the enclosing boundling box and looking for the distance to the center of the new annotation.

@timonegk timonegk changed the title Detect too similar annotations for non bounding boxes Detect too similar annotations for non bounding boxes does not work well enough Dec 6, 2020
@timonegk timonegk changed the title Detect too similar annotations for non bounding boxes does not work well enough Detection of too similar annotations for non bounding boxes does not work well enough Dec 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants