Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types required in bdk 1.0.0-beta.4 #2

Open
6 of 7 tasks
thunderbiscuit opened this issue Aug 16, 2024 · 6 comments
Open
6 of 7 tasks

Types required in bdk 1.0.0-beta.4 #2

thunderbiscuit opened this issue Aug 16, 2024 · 6 comments

Comments

@thunderbiscuit
Copy link
Member

thunderbiscuit commented Aug 16, 2024

Just keeping track of types we need as of the beta 2.

  • Address
  • Transaction
  • Psbt
  • OutPoint
  • TxIn
  • TxOut
  • FeeRate
@rustaceanrob
Copy link
Contributor

I'll work on TxIn

@thunderbiscuit thunderbiscuit changed the title Types required in bdk 1.0.0-beta.2 Types required in bdk 1.0.0-beta.4 Sep 16, 2024
@rustaceanrob
Copy link
Contributor

Next up is Transaction. I will have a look at what API surface we need for bdk-ffi and ldk-node

@notmandatory
Copy link
Member

High level question; based on discussion bitcoindevkit/bdk-ffi#469 do we want to create a new miniscript-ffi crate to put types like PsbtExt(Psbt).finalize() ? or we could include miniscript as a dependency to this crate. I'm leaning to including miniscript here since I don't see any project using something like a miniscript-ffi create and not also needing the bitcoin-ffi types.

@notmandatory
Copy link
Member

notmandatory commented Nov 5, 2024

If we do add miniscript to this crate then we could implement the PsbtExt::finalize() as a function directly on the bitcoin-ffi Psbt type.

@thunderbiscuit
Copy link
Member Author

Yes I recommend we (for now at least) think of bitcoin-ffi as encompassing what we need from the rust-bitcoin org (probably just bitcoin and miniscript but maybe also bitcoin_hashes and core).

@tnull
Copy link
Collaborator

tnull commented Nov 8, 2024

Could also be same repo, but different crates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

4 participants