Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bitcoinjs-gui: colorman: load color definitions #6

Open
killerstorm opened this issue Apr 19, 2013 · 4 comments
Open

bitcoinjs-gui: colorman: load color definitions #6

killerstorm opened this issue Apr 19, 2013 · 4 comments

Comments

@killerstorm
Copy link

Currently color definitions are embedded in code. There should be a way to load them via URL. Perhaps it should be stored in local storage.

(Integration with bitcoinjs-gui front-end is necessary.)

Bounty: 0.5 BTC

@virtimus
Copy link

got it compiled/instaled on my CentOS vm.
Located defs in colorman.js

There should be only one source for defs defined or more ?

Proposed implementation : loading defs configurable via some (hardcoded/configured?) list of sources - ie:

Final defs merged from the list in a sequence.

@killerstorm
Copy link
Author

Well, the general idea is that user should be able to add colors he is interested in, and list of colors should be preserved over page reloads (so that user does not need to add colors each time). Perhaps it should be persisted in same way wallets are. One way to do that is to add color definitions to bitcoinjs-gui wallet object so that they are persisted together.

There are three ways to deal with sources:

  • when user adds a source, store URL and load definitions from that source each time
  • import all definitions from that URL into a local store and forget URL itself
  • import definitions, but remember URL so that it is periodically polled and user is asked whether he wants to download new definitions

Let's not make it too complex from start, whatever is easiest will work.

But I guess there should be a default source of color definitions, for new users, so that they can try it right away without configuring anything. So, yeah, something like localdefsfile.js.

@virtimus
Copy link

OK understood.

So there will be I think two types of sources for a start:

  • local/predefined by local path (ie /somepath/localdefsfile.js);
  • user sources - defined dynamically via web by user (some simple GUI "add/remove/refresh source url's")

Both merged defs data and urls/paths will be stored with bitcoinjs-gui wallet and this will be loaded as current colorman.js/defs member.

That's now clear for me. I think I am able to do the task (I'm fresh to the project) I'll take it next week if still unassigned.

@katuma
Copy link

katuma commented Apr 22, 2013

As much I hate to skip the line, it was kinda stopper for me.

bitcoinx/webcoinx@3de776b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants