Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow configuring icon file #45

Closed
andreasknoepfle opened this issue Nov 15, 2021 · 0 comments · Fixed by #55
Closed

Allow configuring icon file #45

andreasknoepfle opened this issue Nov 15, 2021 · 0 comments · Fixed by #55
Labels
enhancement New feature or request
Milestone
v1.0

Comments

@andreasknoepfle
Copy link
Member

Currently ui_icon needs either inline svgs or an explicitly passed in a file attribute.
When building components that will use ui_icon, it would be great to have a config option to set a
default icon file as MFA (since the icon is probably a route in phoenix) and some README helping with the setup.
Also see #24

https://hexdocs.pm/bitstyles_phoenix/BitstylesPhoenix.Icon.html#content
@andreasknoepfle andreasknoepfle mentioned this issue Nov 15, 2021
Open
4 tasks
@andreasknoepfle andreasknoepfle added the enhancement New feature or request label Nov 15, 2021
@andreasknoepfle andreasknoepfle added this to the v1.0 milestone Nov 15, 2021
andreasknoepfle added a commit that referenced this issue Nov 16, 2021
@andreasknoepfle
[#45] Allow configuring icon file
64f0816 
#45
@andreasknoepfle andreasknoepfle mentioned this issue Nov 16, 2021
Merged
andreasknoepfle added a commit that referenced this issue Nov 17, 2021
@andreasknoepfle
[#45] Allow configuring icon file (#55)
b00cf2d 
* [#45] Allow configuring icon file

#45

* Add changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.0
Development

Successfully merging a pull request may close this issue.

[#45] Allow configuring icon file bitcrowd/bitstyles_phoenix
1 participant
@andreasknoepfle