Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topic header #37

Closed
p1gp1g opened this issue Feb 1, 2025 · 2 comments
Closed

Topic header #37

p1gp1g opened this issue Feb 1, 2025 · 2 comments

Comments

@p1gp1g
Copy link

p1gp1g commented Feb 1, 2025

A topic header has been introduced with 1d104b8.

A Topic header means the push server keeps only the last push message for this topic. So if the servers sends a push message for a removed event, then another push message for a new event while the device is disconnected, the device will not be aware of the removed event at reconnection.

Is that intended ?

@JonathanTreffler
Copy link
Collaborator

Yes, that is currently intended, but might get removed again from the spec to simplify it.
Currently this works well, because the push message does not contain information about what changed, so as long as 1 push message makes it to the client after n changes there is not problem, because the sync will fetch all changes. But the spec (not this implementation yet) now also covers calendar metadata (displayname, color) changes, where that deduplication could be a problem, if a newer metadata change notifications "covers up" a previous content change notification.

@p1gp1g
Copy link
Author

p1gp1g commented Feb 22, 2025

Thanks for the answer ! All of this makes sense 👍 I'm closing it to not pollute your issues

@p1gp1g p1gp1g closed this as completed Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants