Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update “Dual-key” system #66

Open
acalatrava opened this issue Nov 8, 2020 · 1 comment
Open

Update “Dual-key” system #66

acalatrava opened this issue Nov 8, 2020 · 1 comment
Labels
code-cleanup Cleanup or refactoring of the code

Comments

@acalatrava
Copy link
Contributor

Since the bmcrypto dual key exchange we use is actually an Integrated Encryption Scheme (https://en.wikipedia.org/wiki/Integrated_Encryption_Scheme) we should change the name and probably change the KDF algorithm so we don’t use a legacy method as we use now.
@jaytaph
Copy link
Member

jaytaph commented Nov 19, 2020

Also add https://github.com/ethereum/go-ethereum/blob/28080463d2834dfc4e36061930ad721bf8a2482f/crypto/ecies/ecies.go#L232 so we can do ecdsa encryption as well

@jaytaph jaytaph added the code-cleanup Cleanup or refactoring of the code label Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code-cleanup Cleanup or refactoring of the code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jaytaph @acalatrava