Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inv message inventory naming confusion #76

Open
olalonde opened this issue Aug 6, 2015 · 0 comments
Open

Inv message inventory naming confusion #76

olalonde opened this issue Aug 6, 2015 · 0 comments

Comments

@olalonde
Copy link

olalonde commented Aug 6, 2015

Inventory messages contain a property called .inventory which is an array of Invectory instances. This is a bit confusing and unusual as array properties are typically pluralised. One solutions would be to rename the .inventory property to .invs. Alternatively, Invectory could be renamed to InvVector to reflect the common usage (https://en.bitcoin.it/wiki/Protocol_documentation#Inventory_Vectors).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@olalonde