Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add names to types of Lvds fields #623

Open
lmbollen opened this issue Aug 29, 2024 · 0 comments
Open

Add names to types of Lvds fields #623

lmbollen opened this issue Aug 29, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@lmbollen
Copy link
Contributor

Currently we can not use makeTopEntity on designs that use Lvds such as e49623c#diff-7d493e92e4e11a8c6ffe608a1bc3b5870f2bff5f8b01fd105bd4d3fc49152d7eR132-R143
Because this type does not contain the "Name" ::: type annotations that should turn SGMII_RX into SGMII_RX_P and SGMII_RX_N
We probably want lower case annotations similar to https://hackage.haskell.org/package/clash-prelude-1.8.1/docs/Clash-Signal-Internal.html#t:DiffClock to be consistent
@lmbollen lmbollen added the enhancement New feature or request label Aug 29, 2024
@lmbollen lmbollen mentioned this issue Aug 29, 2024
Merged
@lmbollen lmbollen added the good first issue Good for newcomers label Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lmbollen