Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Maybe from DataLink #662

Open
lmbollen opened this issue Oct 28, 2024 · 0 comments
Open

Remove Maybe from DataLink #662

lmbollen opened this issue Oct 28, 2024 · 0 comments

Comments

@lmbollen
Copy link
Contributor

lmbollen commented Oct 28, 2024

Currently the DataLink type used by the scatter unit and gather unit is:

-- | Either contains a @Just (BitVector frameWidth)@ or @Nothing@.
type DataLink frameWidth = Maybe (BitVector frameWidth)

But since all communication is scheduled ahead of time we don't need any flow control mechanisms at this level.
As a workaround we can apply Just to all BitVector frameWidths and use fromMaybe 0 to strip them.

The scatter engines, gather engines, switch and their tests should be adjusted to reflect this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant