Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conversion from dot to png #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

swerter
Copy link

@swerter swerter commented Dec 5, 2018

Add the function to_png, which compiles the dot file into a png file.

Add the function to_png, which compiles the dot file into a png file.
@dunyakirkali
Copy link

This looks quite handy.
Any reason why the MR is still open?

@mindok
Copy link

mindok commented Mar 10, 2024

@dunyakirkali - I'd imagine because it relies on an external command-line dependency (dot) which may or may not be installed. It would probably be better to have the function in the PR defined in your project rather than the library rather than have a library function fail due to a missing dependency that the library has no control over.

@bitwalker
Copy link
Owner

That's essentially the hang up. I think it is useful, and the PR is solid, but I'm hesitant to add a third party dependency, especially one needed for the test suite.

I think my preference would be to have a way to extend libgraph with capabilities like this in the form of third-party packages, as is done for many libraries. I just haven't decided how to handle that yet, and haven't had the time. I've left the PR open for those that wish to use it in their own projects by merging it into a fork, and until I can make a decision on how to move forward with it.

@dunyakirkali
Copy link

Makes sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants