Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-16534] Merge authenticator-android libs and fastlane files #4782

Merged
merged 4 commits into from
Feb 25, 2025

Conversation

vvolkgang
Copy link
Member

🎟️ Tracking

PM-16534

📔 Objective

Merging files to reduce conflicts from the authenticator-android monorepo process.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Feb 25, 2025

Logo
Checkmarx One – Scan Summary & Details73d5e389-4249-4f3c-aaaa-4d0603069188

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.32%. Comparing base (00eb78f) to head (3dfd929).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4782      +/-   ##
==========================================
+ Coverage   89.31%   89.32%   +0.01%     
==========================================
  Files         494      494              
  Lines       41722    41778      +56     
  Branches     5924     5935      +11     
==========================================
+ Hits        37263    37319      +56     
+ Misses       2412     2411       -1     
- Partials     2047     2048       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vvolkgang vvolkgang disabled auto-merge February 25, 2025 21:57
@vvolkgang vvolkgang enabled auto-merge February 25, 2025 21:57
@vvolkgang vvolkgang added this pull request to the merge queue Feb 25, 2025
Merged via the queue into main with commit 64da29f Feb 25, 2025
9 checks passed
@vvolkgang vvolkgang deleted the merge-bwa-files branch February 25, 2025 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants