[PM-15873] Cherrypick: PTR remaining changes

[andrebispo5]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-15873

📔 Objective

Cherrypick from main of remaining PTR fixes into rc branch.
#4784
#4778

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
  issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[github-actions]

Checkmarx One – Scan Summary & Details – a7751329-7585-4a5a-a9d4-be68466fffb9

New Issues (28)

Checkmarx found the following issues in this Pull Request

Severity	Issue	Source File / Package	Checkmarx Insight
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/data/autofill/manager/AutofillTotpManagerImpl.kt: 30	details Method tryCopyTotpToClipboard at line 30 of /app/src/main/java/com/x8bit/bitwarden/data/autofill/manager/AutofillTotpManagerImpl.kt sends user info... Attack Vector
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/passwordhistory/PasswordHistoryViewModel.kt: 136	details Method handleCopyClick at line 136 of /app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/passwordhistory/PasswordHistoryViewModel.kt... Attack Vector
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/passwordhistory/PasswordHistoryViewModel.kt: 135	details Method handleCopyClick at line 135 of /app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/passwordhistory/PasswordHistoryViewModel.kt... Attack Vector
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultViewModel.kt: 531	details Method handleCopyPasswordClick at line 531 of /app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultViewModel.kt sends user informatio... Attack Vector
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModel.kt: 971	details Method Lambda at line 971 of /app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModel.kt sends user information outside the ... Attack Vector
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModel.kt: 615	details Method Lambda at line 615 of /app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModel.kt sends user information outside the ... Attack Vector
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/search/SearchViewModel.kt: 385	details Method handleCopyPasswordClick at line 385 of /app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/search/SearchViewModel.kt sends user infor... Attack Vector
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultViewModel.kt: 530	details Method handleCopyPasswordClick at line 530 of /app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultViewModel.kt sends user informatio... Attack Vector
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt: 890	details Method handleCopyPasswordClick at line 890 of /app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt send... Attack Vector
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt: 889	details Method handleCopyPasswordClick at line 889 of /app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt send... Attack Vector
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt: 1325	details Method handleMasterPasswordRepromptResultReceive at line 1325 of /app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListi... Attack Vector
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt: 1325	details Method handleMasterPasswordRepromptResultReceive at line 1325 of /app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListi... Attack Vector
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt: 1325	details Method handleMasterPasswordRepromptResultReceive at line 1325 of /app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListi... Attack Vector
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt: 1325	details Method handleMasterPasswordRepromptResultReceive at line 1325 of /app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListi... Attack Vector
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt: 1325	details Method handleMasterPasswordRepromptResultReceive at line 1325 of /app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListi... Attack Vector
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/search/SearchViewModel.kt: 384	details Method handleCopyPasswordClick at line 384 of /app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/search/SearchViewModel.kt sends user infor... Attack Vector
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModel.kt: 604	details Method Lambda at line 604 of /app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModel.kt sends user information outside the ... Attack Vector
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModel.kt: 968	details Method Lambda at line 968 of /app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModel.kt sends user information outside the ... Attack Vector
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/createaccount/CreateAccountViewModel.kt: 321	details Method Lambda at line 321 of /app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/createaccount/CreateAccountViewModel.kt sends user information ... Attack Vector
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/createaccount/CreateAccountViewModel.kt: 321	details Method Lambda at line 321 of /app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/createaccount/CreateAccountViewModel.kt sends user information ... Attack Vector
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt: 352	details Method Lambda at line 352 of /app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt sends use... Attack Vector
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt: 352	details Method Lambda at line 352 of /app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt sends use... Attack Vector
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/data/tools/generator/repository/utils/GeneratorRepositoryExtensions.kt: 11	details Method generateRandomString at line 11 of /app/src/main/java/com/x8bit/bitwarden/data/tools/generator/repository/utils/GeneratorRepositoryExtension... Attack Vector
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/deleteaccount/DeleteAccountViewModel.kt: 94	details Method Lambda at line 94 of /app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/deleteaccount/DeleteAccountViewMode... Attack Vector
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt: 238	details Method Lambda at line 238 of /app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt sends use... Attack Vector
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt: 260	details Method Lambda at line 260 of /app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt sends use... Attack Vector
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt: 249	details Method Lambda at line 249 of /app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt sends use... Attack Vector
	Use_of_Hardcoded_Password	/app/src/main/java/com/x8bit/bitwarden/data/autofill/util/HtmlInfoExtensions.kt: 20	details The application uses the hard-coded password "password" for authentication purposes, either using it to verify users' identities, or to access anot... Attack Vector

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.31%. Comparing base (80bd1bf) to head (80dbbf9).
Report is 2 commits behind head on release/2025.02-rc16.

Additional details and impacted files

@@                   Coverage Diff                    @@
##           release/2025.02-rc16    #4785      +/-   ##
========================================================
+ Coverage                 89.29%   89.31%   +0.01%     
========================================================
  Files                       492      492              
  Lines                     41644    41691      +47     
  Branches                   5919     5925       +6     
========================================================
+ Hits                      37187    37235      +48     
+ Misses                     2411     2410       -1     
  Partials                   2046     2046              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.