Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-18451] Elevated privileges do not exempt from remove pin unlock policy #4791

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

andrebispo5
Copy link
Contributor

Backport: #4788

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-18451

📔 Objective

Revert changes of previous PR: #4786
Add exception to Remove Unlock With Pin policy

📸 Screenshots

Screen.Recording.2025-02-26.at.09.51.57.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details74db5806-d5d9-49c9-87d0-732f09e2fb04

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.32%. Comparing base (64da29f) to head (c526ccc).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4791      +/-   ##
==========================================
- Coverage   89.32%   89.32%   -0.01%     
==========================================
  Files         494      494              
  Lines       41748    41738      -10     
  Branches     5927     5921       -6     
==========================================
- Hits        37291    37281      -10     
  Misses       2409     2409              
  Partials     2048     2048              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrebispo5 andrebispo5 added this pull request to the merge queue Feb 26, 2025
Merged via the queue into main with commit d04ac5e Feb 26, 2025
9 checks passed
@andrebispo5 andrebispo5 deleted the pm-18451/backport-exempt-from-policies branch February 26, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants