Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-18655] sync with bitwarden/template #4795

Merged
merged 3 commits into from
Feb 26, 2025
Merged

Conversation

vvolkgang
Copy link
Member

🎟️ Tracking

PM-18655

📔 Objective

Update common files to the latest version in our template.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@vvolkgang vvolkgang added this pull request to the merge queue Feb 26, 2025
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.32%. Comparing base (64da29f) to head (c8d85e5).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4795   +/-   ##
=======================================
  Coverage   89.32%   89.32%           
=======================================
  Files         494      494           
  Lines       41748    41748           
  Branches     5927     5927           
=======================================
  Hits        37291    37291           
  Misses       2409     2409           
  Partials     2048     2048           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into main with commit 55e0356 Feb 26, 2025
9 checks passed
@vvolkgang vvolkgang deleted the repo-migration/sync-template branch February 26, 2025 15:26
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details7387c3c8-404c-4873-8018-50365e3b9e1b

Great job, no security vulnerabilities found in this Pull Request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants