Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contrasts and Favicons error #13176

Open
1 task done
T00rk opened this issue Jan 31, 2025 · 7 comments
Open
1 task done

Contrasts and Favicons error #13176

T00rk opened this issue Jan 31, 2025 · 7 comments
Labels
browser Browser Extension bug

Comments

@T00rk
Copy link

T00rk commented Jan 31, 2025

Steps To Reproduce

Open extension dialog

Expected Result

Should show website favicons
"Fill" button text should be readable

Actual Result

Image

Image

Screenshots or Videos

No response

Additional Context

No response

Operating System

Linux

Operating System Version

NixOs 24.11

Web Browser

Brave

Browser Version

1.74.51

Build Version

2025.1.2

Issue Tracking Info

  • I understand that work is tracked outside of Github. A PR will be linked to this issue should one be opened to address it, but Bitwarden doesn't use fields like "assigned", "milestone", or "project" to track progress.
@T00rk T00rk added browser Browser Extension bug labels Jan 31, 2025
@bitwarden-bot
Copy link

Thank you for reporting this issue! We've added this to our internal tracking system.
ID: PM-17810

@T00rk
Copy link
Author

T00rk commented Jan 31, 2025

The problem with contrast was due to BW not having selected the correct Theme (I don't know why it has been reset).
It's now fixed.
Favicons are still not showing

@cksapp
Copy link

cksapp commented Jan 31, 2025

@T00rk are you by chance using the Nord theme?

If so this may be the same concern as #13089. Seems that currently only 'Light' and 'Dark' themes are currently supported by the Bitwarden client applications.

@jducaud
Copy link

jducaud commented Feb 1, 2025

Hello,

Favicons are not showing anymore for those clients:

  • Bitwarden 2025.1.3 (Windows 11)
  • Bitwarden 2025.1.3 (Ubuntu 24.04 - Flatpak)
  • Bitwarden 2024.12.4 (Firefox 134.0.2 - extension)

Favicons are still showing for those clients:

  • Bitwarden 2025.1.1 (Android 13)
  • Bitwarden 2025.1.2 (iPadOS 18.2.1)

@T00rk
Copy link
Author

T00rk commented Feb 1, 2025

@cksapp yes I was using Nord theme

@blasiusx
Copy link

blasiusx commented Feb 3, 2025

Hello,

Favicons are not showing anymore for those clients:

  • Bitwarden 2025.1.3 (Windows 11)
  • Bitwarden 2025.1.3 (Ubuntu 24.04 - Flatpak)
  • Bitwarden 2024.12.4 (Firefox 134.0.2 - extension)

Favicons are still showing for those clients:

  • Bitwarden 2025.1.1 (Android 13)
  • Bitwarden 2025.1.2 (iPadOS 18.2.1)

I can only confirm that. The problem is exactly as described. The web icons are not displayed. Except in iOS and Google Chrome, where they are only displayed. The problem has only been present since the new Bitwarden version.

@jducaud
Copy link

jducaud commented Feb 8, 2025

Hello,

Favicons are not showing anymore for those clients:

* Bitwarden 2025.1.3 (Windows 11)

* Bitwarden 2025.1.3 (Ubuntu 24.04 - Flatpak)

* Bitwarden 2024.12.4 (Firefox 134.0.2 - extension)

Favicons are still showing for those clients:

* Bitwarden 2025.1.1 (Android 13)

* Bitwarden 2025.1.2 (iPadOS 18.2.1)

My bad. A recent update (2025.1.1, i.e. 1.33.1) of my self-hosted Vaultwarden server fixed this issue.

Favicons are showing again for those clients:

  • Bitwarden 2025.1.3 (Windows 11) (no version change)
  • Bitwarden 2025.1.4 (Ubuntu 24.04 - Flatpak) (version change from 2025.1.3 to 2025.1.4)
  • Bitwarden 2024.12.4 (Firefox 135.0.0 - extension) (no version change, except for Firefox)

It was not a client issue, it was a server one. But I cannot explain why there were (at least for me) 2 clients which correctly displayed the favicons (Android and iPadOS ones)...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser Browser Extension bug
Projects
None yet
Development

No branches or pull requests

5 participants