Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrong comment on nRuleChangeActivationThreshold #41

Open
cryptozeny opened this issue Nov 14, 2018 · 1 comment
Open

wrong comment on nRuleChangeActivationThreshold #41

cryptozeny opened this issue Nov 14, 2018 · 1 comment
Labels
documentation Manuals and User Documentation

Comments

@cryptozeny
Copy link
Member

cryptozeny commented Nov 14, 2018 •
edited
Loading

BitZenyPlus/src/chainparams.cpp

Line 87 in 31e9415

consensus.nRuleChangeActivationThreshold = 13440; // 95% 

consensus.nRuleChangeActivationThreshold = 13440; // 95%
consensus.nMinerConfirmationWindow = 13440; // nPowTargetTimespan / nPowTargetSpacing

i think it's not 95% but 100%. threshold == window

its not an actual problem but a wrong comment.
cryptozeny referenced this issue Nov 14, 2018
BitZeny: Fix BIP9 parameters for future release
78184c3
@cryptozeny cryptozeny mentioned this issue Nov 17, 2018
Open
cryptozeny added a commit that referenced this issue Nov 17, 2018
@cryptozeny
Fix an invalid comment: 95% >> 100%
5b74cc5 
#41

I think this 100% is not good for the consensus. We need a discussion about this in near future.

Fixing a comment is a trivial thing, but this parameter is important thing.
@cryptozeny cryptozeny mentioned this issue Nov 17, 2018
Merged
@cryptozeny cryptozeny added the documentation Manuals and User Documentation label Apr 7, 2019
@cryptozeny
Copy link
Member Author

this wrong comment is already fixed, but not completely resolved. so I do not close until this issue is completely cleared.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Manuals and User Documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cryptozeny