-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code cleaning #1
Comments
Hi, can I give this a shot? |
@abuZayed15 Sure, go right ahead! |
Thank you @bjorno43 for having me work on this issue. I might have a few questions as I am a beginner in C# so please bear with me :) Thanks! |
@abuZayed15 I would start by looking at all the exceptions. You're going to find a lot of duplicated in there, or very close duplicates (strings repeating themselves). This can most likely be improved by creating some private strings within the class and have them use those instead. That will improve maintainability. Make sure you use logical variable naming and stick to camelCase conventions. |
@bjorno43 Got it. I will make some changes and raise a PR. If you don't like something or you want me to change a few more things I can always push new commits to the same PR. Thanks for the direction! |
If it's not an issue, I'd also like to contribute to this code cleanup! My goal will be to ensure this project adheres to the SOLID principles as much as possible. |
@ajonestechnology Sorry, I've been away for a few days (weekend). You're more than welcome to work on this as well. Just make sure you keep it up to date with merged PRs so there won't be any conflicts. Even if the PRs you submit can't be merged yet due to conflicts, I'll make sure to label them as |
Much appreciated! |
@bjorno43 i make a little improvement on code of HelpForm.cs file, can i open a pull request? |
@sYonashiro Of course you can :) I'll review it and if it helps, I'll accept it. If not, I'll give you some pointers on how you might be able to improve your PR |
#9 I make some changes in HelpForm.cs file, hope you like it 👍 |
@sYonashiro I've reviewed and accepted it. Thanks for your contribution 👍 |
This project can honestly use a lot of code cleaning. I've decided to allow it to participate in the hacktoberfest event for this as it's not too difficult to do and should therefor be doable by most beginner / intermediate C# developers. For example: Exception handlers can most likely be improved quite a bit.
The text was updated successfully, but these errors were encountered: