Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleaning #1

Open
bjorno43 opened this issue Oct 4, 2020 · 12 comments
Open

Code cleaning #1

bjorno43 opened this issue Oct 4, 2020 · 12 comments
Assignees
Labels

Comments

@bjorno43
Copy link
Owner

bjorno43 commented Oct 4, 2020

This project can honestly use a lot of code cleaning. I've decided to allow it to participate in the hacktoberfest event for this as it's not too difficult to do and should therefor be doable by most beginner / intermediate C# developers. For example: Exception handlers can most likely be improved quite a bit.

@ceterisp
Copy link

ceterisp commented Oct 5, 2020

Hi, can I give this a shot?

@bjorno43
Copy link
Owner Author

bjorno43 commented Oct 5, 2020

@abuZayed15 Sure, go right ahead!

@ceterisp
Copy link

ceterisp commented Oct 6, 2020

Thank you @bjorno43 for having me work on this issue. I might have a few questions as I am a beginner in C# so please bear with me :)
For starters, is there anything specific you want me to refactor?

Thanks!

@bjorno43
Copy link
Owner Author

bjorno43 commented Oct 7, 2020

@abuZayed15 I would start by looking at all the exceptions. You're going to find a lot of duplicated in there, or very close duplicates (strings repeating themselves). This can most likely be improved by creating some private strings within the class and have them use those instead. That will improve maintainability. Make sure you use logical variable naming and stick to camelCase conventions.

@ceterisp
Copy link

ceterisp commented Oct 7, 2020

@bjorno43 Got it. I will make some changes and raise a PR. If you don't like something or you want me to change a few more things I can always push new commits to the same PR. Thanks for the direction!

@ceterisp ceterisp mentioned this issue Oct 9, 2020
@ajonestechnology
Copy link

If it's not an issue, I'd also like to contribute to this code cleanup! My goal will be to ensure this project adheres to the SOLID principles as much as possible.

@bjorno43
Copy link
Owner Author

@ajonestechnology Sorry, I've been away for a few days (weekend). You're more than welcome to work on this as well. Just make sure you keep it up to date with merged PRs so there won't be any conflicts. Even if the PRs you submit can't be merged yet due to conflicts, I'll make sure to label them as hacktoberfest-accepted before the end of that event so you at least get that in return for your efforts :)

@ajonestechnology
Copy link

@ajonestechnology Sorry, I've been away for a few days (weekend). You're more than welcome to work on this as well. Just make sure you keep it up to date with merged PRs so there won't be any conflicts. Even if the PRs you submit can't be merged yet due to conflicts, I'll make sure to label them as hacktoberfest-accepted before the end of that event so you at least get that in return for your efforts :)

Much appreciated!

@sYonashiro
Copy link
Contributor

@bjorno43 i make a little improvement on code of HelpForm.cs file, can i open a pull request?

@bjorno43
Copy link
Owner Author

@sYonashiro Of course you can :) I'll review it and if it helps, I'll accept it. If not, I'll give you some pointers on how you might be able to improve your PR

@sYonashiro
Copy link
Contributor

#9 I make some changes in HelpForm.cs file, hope you like it 👍

@bjorno43
Copy link
Owner Author

@sYonashiro I've reviewed and accepted it. Thanks for your contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants