Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests flaky #17

Open
benesch opened this issue Aug 18, 2022 · 8 comments
Open

Integration tests flaky #17

benesch opened this issue Aug 18, 2022 · 8 comments

Comments

@benesch
Copy link
Contributor

benesch commented Aug 18, 2022

I occasionally see the following flake when running integration tests locally:

exec curl output:000 i:1
thread 'integration_tests::remote_port_forwarding::simple_with_tokio' panicked at 'assertion failed: `(left == right)`
  left: `"000"`,
 right: `"200"`', async-ssh2-lite/tests/integration_tests/remote_port_forwarding.rs:121:17

It seems like something is occasionally corrupting data. Appears unrelated to the issue documented in #16, because I see this flake both with and without the change in #16.

@vkill
Copy link
Contributor

vkill commented Aug 26, 2022

@benesch I know this problem, but I also don't know the exact reason.

@benesch
Copy link
Contributor Author

benesch commented Oct 27, 2022

Hi @vkill, was this fixed? I don’t see anything related in the commit history.

@vkill
Copy link
Contributor

vkill commented Oct 27, 2022

@benesch , Don't fixed, Because I don't know how to fix it.

@benesch
Copy link
Contributor Author

benesch commented Nov 13, 2022

Could we keep this issue open until it's resolved? Even if you don't know how to fix it, perhaps someone else who does will come along!

@vkill vkill reopened this Nov 13, 2022
@vkill
Copy link
Contributor

vkill commented Nov 13, 2022

Yes, maybe the problem is ssh itself.

@vkill
Copy link
Contributor

vkill commented Nov 20, 2022

Hi @benesch

Can you test #23 ?

@vkill vkill closed this as completed in 8734167 Nov 21, 2022
vkill added a commit that referenced this issue Nov 21, 2022
@vkill vkill reopened this Nov 21, 2022
@vkill
Copy link
Contributor

vkill commented Nov 21, 2022

Hi, @benesch

This is not a bug, we should wait for the port to listen because the status 000 maybe is Connection failed.
Please refer to #25 and f0254a5

@vkill vkill closed this as completed Jan 8, 2023
@vkill vkill reopened this Jan 20, 2023
@vkill
Copy link
Contributor

vkill commented Jan 20, 2023

assert!(vec!["200".into(), "000".into()].contains(&s));

This problem still exists. temporarily skip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants