Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github_org update validate_org function #1852

Open
domwhewell-sage opened this issue Oct 14, 2024 · 3 comments
Open

Github_org update validate_org function #1852

domwhewell-sage opened this issue Oct 14, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@domwhewell-sage
Copy link
Contributor

Description
Now that a Yara helper has been created to extract in-scope hostnames from strings can the validate function in github_org be modified to use this helper instead

@domwhewell-sage domwhewell-sage added the enhancement New feature or request label Oct 14, 2024
@domwhewell-sage
Copy link
Contributor Author

Also it occurs to me that git repos raised by the code_repository module bypass validation checks so we could end up downloading out of scope repos.

I think the other regexs could do this as well with the exception of postman repos as the postman_download module does in-scope check then

@TheTechromancer
Copy link
Collaborator

git repos raised by the code_repository module bypass validation checks so we could end up downloading out of scope repos

Hmm, scope distance should keep those repos reasonably close. Typically if a code repo is discovered via a link on a webpage etc, it's interesting even if it's not in scope.

Unless it's producing a lot of junk, I don't think we should need to validate every one.

Although if our goal is to discover in-scope users/orgs, consuming code_repository (or more specifically SOCIAL) could be a good way to do that, especially if the ORG_STUB doesn't match the username. Are we already doing this with GitHub?

@domwhewell-sage
Copy link
Contributor Author

Yeh github_org is consuming the SOCIAL events and validating if they are in scope or not

I was thinking of the full CODE_REPOSITORY url which there is no validation for currently. But as you say it's only a few events

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants