Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile layout looks broken #1251

Open
pmpinto opened this issue Jan 22, 2025 · 3 comments · May be fixed by #1255
Open

Mobile layout looks broken #1251

pmpinto opened this issue Jan 22, 2025 · 3 comments · May be fixed by #1255

Comments

@pmpinto
Copy link

pmpinto commented Jan 22, 2025

Hey @blakadder! I sent you an email sometime ago but never got a reply, so here I am.

First things first, thanks a lot for this list/repository! It's very useful, especially for new zigbee users like myself.
The issue I find with it though, is that I use it mostly on my phone, and as you can see below, the layout is broken:

Image

Image

These are the issues I could find:

  1. The images look squished;
  2. There's no way to see the compatibility icons without scrolling horizontally;
  3. The product names need more horizontal space to be easily readable;
  4. The menu doesn't scroll vertically to reveal all menu items;

Would you be willing to accept a PR where I try to fix them? Can't promise anything, especially since you're using tables and I'm not sure how comfortable you would be moving to another approach. But at least I would like to give this at try.

I just wouldn't like to spend time looking into this if you're not willing to change it in the first place.

@pmpinto
Copy link
Author

pmpinto commented Jan 24, 2025

Image

@blakadder How do you feel about this proposal, in general?

@blakadder
Copy link
Owner

Looks great!

@pmpinto
Copy link
Author

pmpinto commented Jan 25, 2025

Good to know!

I'll work more on this eventually. Polish a few things and open a PR when it's ready.

Cheers!

@pmpinto pmpinto linked a pull request Jan 30, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants