Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Apple Touch Icons #156

Open
uxder opened this issue Jan 24, 2022 · 1 comment
Open

Support Apple Touch Icons #156

uxder opened this issue Jan 24, 2022 · 1 comment

Comments

@uxder
Copy link
Member

uxder commented Jan 24, 2022

Basic icons are currently supported but should we have a way to defined multiple sizes and apple-touch-icons?

<link rel="apple-touch-icon" sizes="180x180" href="/apple-touch-icon.png">
<link rel="icon" type="image/png" sizes="32x32" href="/favicon-32x32.png">
<link rel="icon" type="image/png" sizes="16x16" href="/favicon-16x16.png">

https://github.com/blinkk/amagaki-plugin-page-builder/blob/main/src/page-builder.ts#L400

@jeremydw
Copy link
Member

Let's definitely add support for this if it's useful and needed in Safari. Can you do a quick check and see how other tools generate their head + link elements? We can express the configuration the same way they do.

@jeremydw jeremydw transferred this issue from blinkk/amagaki-plugin-page-builder Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants