Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoded BASE_URL causing weird requests #49

Open
ghost opened this issue Apr 3, 2020 · 0 comments
Open

Hardcoded BASE_URL causing weird requests #49

ghost opened this issue Apr 3, 2020 · 0 comments

Comments

@ghost
Copy link

ghost commented Apr 3, 2020

We have some monitoring at Learning Machine that blocks weird request and one we are noticing is coming from the android wallet. In some cases it seems to make a request to learning machine looking for an issuer profile. We have yet to reproduce this or locate the exact place it is coming from, but we've done a little checking.

There is a hardcoded reference to learning machine here:

public static final String BASE_URL = "https://certificates.learningmachine.com";

And it's being injected somewhere from here:

Retrofit provideIssuerRetrofit(@Named("issuer") OkHttpClient okHttpClient) {

I'm unfamiliar with this code base or how android injection works. We also haven't had any reports of this yet so it's TBD whether it's actually user facing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants