Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connectWallet with autoSelect disables all wallets list #2184

Open
1 task done
josue-palmera opened this issue Apr 30, 2024 · 0 comments
Open
1 task done

connectWallet with autoSelect disables all wallets list #2184

josue-palmera opened this issue Apr 30, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@josue-palmera
Copy link

josue-palmera commented Apr 30, 2024

Current Behavior

I'm trying to autoSelect WalletConnect but when I do, I get an error that I don't have supported wallets on the browser.

Passing autoSelect to connect wallet like this

let wallets = await onboard.connectWallet({
      autoSelect: { label: 'WalletConnect', disableModals: false },
    })

or like this

let wallets = await onboard.connectWallet({
      autoSelect: 'WalletConnect',
    })

It removes our supported wallets
image

A workaround is passing disableModals: true but it hides the appMetadata and we would like to still show it
image

Without autoselect these are our supported wallets
image

Expected Behavior

Keep the supported wallets visible when passing data to autoSelect and the modal is showing

Steps To Reproduce

  1. Add a list of supported wallets to the Onboard initialization. We are trying including WalletConnect
  2. Call onboard.connectWallet(options) where options is
let wallets = await onboard.connectWallet({
      autoSelect: { label: 'WalletConnect', disableModals: false },
    })

or

let wallets = await onboard.connectWallet({
      autoSelect: 'WalletConnect',
    })
  1. Connect and see that the supported wallet disappear and show an error

What package is effected by this issue?

@web3-onboard/core

Is this a build or a runtime issue?

Runtime

Package Version

2.21.2

Node Version

20.11.1

What browsers are you seeing the problem on?

Firefox, Chrome, Safari

Relevant log output

No response

Anything else?

No response

Sanity Check

  • If this is a build issue, I have included my build config. If this is a runtime issue, I have included reproduction steps and/or a Minimal, Reproducible Example.
@josue-palmera josue-palmera added the bug Something isn't working label Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants