Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide what to do with default logic #14

Open
leviska opened this issue Feb 22, 2023 · 0 comments
Open

Decide what to do with default logic #14

leviska opened this issue Feb 22, 2023 · 0 comments

Comments

@leviska
Copy link
Collaborator

leviska commented Feb 22, 2023

By spec it seems that json parsing should work like serde(default), i.e. if field is missing and not optional, we should make it default
But, for example in go, this is an option, and you can assert that all fields are provided
Right now we assert that all non optional fields are required
In rust, it's common to use parsing as validation, so it's not clear, should we implement this logic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant