From 5683b7643da02a0af48b7cd06effd47c1357c8a1 Mon Sep 17 00:00:00 2001 From: Jonathan Lee Date: Wed, 14 Jun 2023 06:24:41 +0000 Subject: [PATCH] [wpt-exporter] Do not export `PRESUBMIT.py` files This change stops the exporter from exporting `PRESUBMIT.py` files, which are Chromium-only. web-platform-tests/wpt#40539 retroactively deletes one such accidentally exported file. Bug: None Change-Id: Ifbea39d61abadacf4d2e7bfba4db3731bc57f970 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4613305 Auto-Submit: Jonathan Lee Reviewed-by: Weizhong Xia Commit-Queue: Weizhong Xia Cr-Commit-Position: refs/heads/main@{#1157376} --- third_party/blink/tools/blinkpy/w3c/common.py | 1 + third_party/blink/tools/blinkpy/w3c/common_unittest.py | 2 ++ 2 files changed, 3 insertions(+) diff --git a/third_party/blink/tools/blinkpy/w3c/common.py b/third_party/blink/tools/blinkpy/w3c/common.py index 847380ed73d6e7..89b3d9021ee90d 100644 --- a/third_party/blink/tools/blinkpy/w3c/common.py +++ b/third_party/blink/tools/blinkpy/w3c/common.py @@ -97,6 +97,7 @@ def is_basename_skipped(basename): 'OWNERS', # https://crbug.com/584660 https://crbug.com/702283 'reftest.list', # https://crbug.com/582838 'DIR_METADATA', # https://crbug.com/1103374 + 'PRESUBMIT.py', ] return (basename in skipped_basenames or is_testharness_baseline(basename) or basename.startswith('.') or is_disallowed_ini(basename)) diff --git a/third_party/blink/tools/blinkpy/w3c/common_unittest.py b/third_party/blink/tools/blinkpy/w3c/common_unittest.py index 753320dde749d1..5248f0a3b22a8a 100644 --- a/third_party/blink/tools/blinkpy/w3c/common_unittest.py +++ b/third_party/blink/tools/blinkpy/w3c/common_unittest.py @@ -120,6 +120,8 @@ def test_is_file_exportable(self): )) self.assertFalse( is_file_exportable(RELATIVE_WPT_TESTS + 'dom/historical.html.ini')) + self.assertFalse( + is_file_exportable(RELATIVE_WPT_TESTS + 'html/tools/PRESUBMIT.py')) def test_is_file_exportable_asserts_path(self): # Rejects basenames.