Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cart is not cleaned at the end of the session #41

Open
marfago opened this issue Dec 3, 2014 · 3 comments
Open

Cart is not cleaned at the end of the session #41

marfago opened this issue Dec 3, 2014 · 3 comments

Comments

@marfago
Copy link

marfago commented Dec 3, 2014

After adding some products to the cart, if you log out and log in again with a different user you will see the cart still containing the previous items. Looks like the cart cookie is not removed at logout.

@rnixx
Copy link
Member

rnixx commented Dec 3, 2014

True, cart cookie is not removed when user logs out.

@marfago
Copy link
Author

marfago commented Dec 4, 2014

Is that behavior correct? Shouldn't the cookie be associated to the specific user?

@rnixx
Copy link
Member

rnixx commented Dec 4, 2014

True, this would be the clean solution.

Here are the locations where user id needs to be considered if user is logged in, anonymous shopping sessions needs to be possible though

https://github.com/bluedynamics/bda.plone.cart/blob/master/src/bda/plone/cart/browser/cart.js#L113
https://github.com/bluedynamics/bda.plone.cart/blob/master/src/bda/plone/cart/browser/cart.js#L440

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants