Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test plugin #1

Open
LETARTARE opened this issue Jul 28, 2019 · 6 comments
Open

Test plugin #1

LETARTARE opened this issue Jul 28, 2019 · 6 comments

Comments

@LETARTARE
Copy link

LETARTARE commented Jul 28, 2019

Hello,
I just built this extension for 'cb-11798 (sdk143)' under 'VISTA. business SP2 32bits' only with wx28 and TDM-510
I used $ (TARGET_NAME) in the project file.
I changed the 'manifest.xml' with sdk = 1.43.0

1- Target 'create_plugin_wx28'

  • correct compilation
  • manual installation gives an error :

Manager failed to load XRC resource 'U:\Donnees\Svn_Compile\Cb\Tdm5103\cb-11798-sdk143-q\src\output\share\codeblocks\cbBuildTools.zip'.

If I delete in "Pre/post build steps"

zip -j9 $(TARGET_NAME)\cbBuildTools.zip images*
zip -j9 $(TARGET_NAME)\cbBuildTools.zip res*

  • correct compilation
  • correct manual installation and we can use the plugin
  • but if you manually uninstall the plugin: CB crashe !
    So I used 'WhatIsHang' de 'Nirsoft' to recover the cause of the error, and here is the crash file : crash_cbBuildTools.zip
    I also recovered 'codeblock.rpt' :
    codeblocks.zip

2- Target 'to_cb_wx28'

  • the errors are identical ...
@bluehazzard
Copy link
Owner

Hi, thank you for the report.
The loading should be fixed with 17ec2bd for the uninstalling the plugin, i think this is a codeblocks bug. Haven't you posted a bug report on SF and also a fix for this? I have to search it....

@bluehazzard
Copy link
Owner

probably this bug: https://sourceforge.net/p/codeblocks/tickets/777/

@LETARTARE
Copy link
Author

LETARTARE commented May 11, 2020

Hi, I think I found the mistake.
You are using a global variable 'm_buildTargetsPanel' which is a pointer initialized by 'new' : you have to release it in 'OnRelease(...)' !!!
This removes the crash of C::B when uninstalling the plugin.
Have a nice day

@bluehazzard
Copy link
Owner

Thank you for the finding! Should be fixed in the commit above adf4cf5

@bluehazzard
Copy link
Owner

Or not.. now i get a crash aftre closing codeblocks...

@bluehazzard bluehazzard reopened this May 17, 2020
@LETARTARE
Copy link
Author

Hello,
I had a free moment and looked again. I think I found the mistake.
In 'cbBuildTools::BuildMenu(wxMenuBar* menuBar)', do not use a global variable 'wxMenu * m_subMenu' , but a local variable that will be built and deleted at each call.
I don't crash anymore when I close 'C::B-12091'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants