Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotate images cleanly on mobile #7452

Open
prohr opened this issue Jan 14, 2025 · 0 comments
Open

Rotate images cleanly on mobile #7452

prohr opened this issue Jan 14, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@prohr
Copy link

prohr commented Jan 14, 2025

Steps to Reproduce

To feel fully immersive, rotating an image should smoothly toggle only the size + orientation (in a single step). Unlike the simple fix which was landed to close #624, please don't also reset other things about the view state (like whether the alt text + controls are displayed)

  1. Tap on a wide image to display fullscreen (portrait)
  2. Tap once to get rid of alt text + controls
  3. Rotate device
  4. Rotate device back

Expected behavior:

3a. Immediately see fullscreen landscape image
4a. Immediately see fullscreen portrait image

Actual behavior:

3a. Brief peek at missized landscape image
3b. Image resizes correctly, but underneath alt text + controls
3c. Tap to get rid of the overlay

4a, 4b, 4c. Similar multistep process for portrait

Attachments

screen-20250114-132119.mp4

Rotating the image here:

https://bsky.app/profile/carlbergstrom.com/post/3lfh2vt36ys2e

What platform(s) does this occur on?

Android

Device Info

Pixel 6a

What version of the app are you using?

Build version: 1.96.3.507; Bundle info: 9f075b1 (prod); Bundle date: 24123121; Platform: android; Platform version: 34

Additional Information

The two-step resizing effect seems to be more noticeable for images which don't have alt text+/or which have a less square aspect ratio

It's also worth considering how to handle rotation when the image is already zoomed in. Simplest implementation would rezoom to fit the new viewport (fullscreen). More immersive implementations might try to preserve the zoom level +/or focal point (but have special cases to consider when that doesn't "fit")

@prohr prohr added the bug Something isn't working label Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant