Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate if we can get rid of the await coro in test_async_status_success_if_cancelled #288

Closed
coretl opened this issue May 7, 2024 · 2 comments
Closed

Investigate if we can get rid of the await coro in test_async_status_success_if_cancelled #288

coretl opened this issue May 7, 2024 · 2 comments
Assignees
@jsouter
Milestone
1.0

Comments

@coretl
Copy link
Collaborator

coretl commented May 7, 2024 

          Unfortunately not really applicable in this case, see: https://github.com/bluesky/ophyd-async/tree/try_with_asyncio_timeout which has the same problem but is much more complicated

Originally posted by @dperl-dls in #176 (comment)
@coretl coretl mentioned this issue May 7, 2024
Merged
@abbiemery abbiemery added this to the 1.0 milestone Jul 29, 2024
@jsouter
Copy link
Contributor

jsouter commented Oct 17, 2024

I think this was addressed here: #318

@coretl
Copy link
Collaborator Author

coretl commented Oct 17, 2024

Good point!

@coretl coretl closed this as completed Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsouter jsouter

Labels
None yet
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
3 participants
@abbiemery @coretl @jsouter