Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some tests fail on 3.12 - and should be failing on older versions #520

Open
d-perl opened this issue Aug 14, 2024 · 7 comments
Open

Some tests fail on 3.12 - and should be failing on older versions #520

d-perl opened this issue Aug 14, 2024 · 7 comments

Comments

@d-perl
Copy link
Contributor

d-perl commented Aug 14, 2024

In testing the new p4p release I came across some test failures which I think are wrong, in particular tests/core/test_mock_signal_backend.py::test_blocks_during_put

In lines 186 and 187 I believe this should test for "first_value" as the signal shouldn't have changed yet with puts blocked - this works correctly on python 3.12 but not earlier versions.

@d-perl d-perl changed the title Some tests fail on 3.12 Some tests fail on 3.12 - and should be failing on older versions Aug 14, 2024
@d-perl
Copy link
Contributor Author

d-perl commented Aug 14, 2024

similarly

async def test_arming_trig_modes(test_advimba: advimba.VimbaDetector):
fails, I believe because these sets are not awaited - @jwlodek do you think this is correct?

@jwlodek
Copy link
Member

jwlodek commented Aug 14, 2024

Indeed I believe those should be awaited. It's interesting that that would not have been caught in tests before

@d-perl
Copy link
Contributor Author

d-perl commented Aug 14, 2024

Great. I've fixed these in my python 3.12 branch https://github.com/bluesky/ophyd-async/tree/update_p4p_and_py312 but am waiting on another release of p4p built against numpy 2 for python versions 3.11 and 10 before it can be merged

@coretl
Copy link
Collaborator

coretl commented Nov 22, 2024

@dperl-dls is this still relevant?

@d-perl
Copy link
Contributor Author

d-perl commented Nov 22, 2024

@coretl probably, I guess there's still no 3.12 in CI here so it seems likely

@coretl
Copy link
Collaborator

coretl commented Nov 22, 2024

Might be fixed by #655

@d-perl
Copy link
Contributor Author

d-perl commented Nov 22, 2024

not clear, I started looking at it and came across the event loop error there, when I ignored it several tests were still failing on 3.12, didn't look into it any further

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants