Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PositionerBase move command, bug or intended? #1184

Open
cappel89 opened this issue Mar 28, 2024 · 0 comments
Open

PositionerBase move command, bug or intended? #1184

cappel89 opened this issue Mar 28, 2024 · 0 comments

Comments

@cappel89
Copy link

cappel89 commented Mar 28, 2024 •
edited
Loading

The PositionerBase method .set takes wait as an argument and calls .move method (with wait).
However, the .move from PositionerBase immediately crashes with
TypeError: PositionerBase.move() got an unexpected keyword argument 'wait'

It seems that this problem is known- see DocString of PositionerBase.

To me it seems unintuitive that the base class crashes immediately. If the base class is not intended to be used directly, I believe it should be turned into an ABC. Or implement the move method, i.e. as for the PVPositioner.
mguijarr pushed a commit to mguijarr/ophyd that referenced this issue Apr 8, 2024
fix(bluesky#1184): PositionerBase as an ABC to ensure .egu and .move(…
7687519 
…) are overwritten in subclasses
mguijarr pushed a commit to mguijarr/ophyd that referenced this issue Apr 8, 2024
fix(bluesky#1184): PositionerBase as an ABC to ensure .egu and .move(…
50e7658 
…) are overwritten in subclasses
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cappel89