Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MATLAB version requirements (Re: vecnorm, min(...,'all')) #1

Open
ahbarnett opened this issue Nov 25, 2020 · 2 comments
Open

MATLAB version requirements (Re: vecnorm, min(...,'all')) #1

ahbarnett opened this issue Nov 25, 2020 · 2 comments

Comments

@ahbarnett
Copy link

ahbarnett commented Nov 25, 2020

Hi Bobbie,
My attempt to run the test codes failed on Matlab R2017a due to:

  • missing function vecnorm.m
    Introduced in R2017b

  • min(..,'all')
    https://www.mathworks.com/help/matlab/ref/min.html
    M = min(A,[],'all') finds the minimum over all elements of A. This syntax is valid for MATLAB® versions R2018b and later.
    You could replace by min(min(...)) and make this more backward-compatible.

So, it would be great if you list the version requirement, and any Toolboxes needed, in your README.md.
Thanks, Alex

@ahbarnett
Copy link
Author

I ran the tests in R2020a and they work - very nice.

PS if my BIE3D codes were useful - looks like the double PTR and test geometries were borrowed - you may want to acknowledge that in the preprint...;)

PPS we call the twisted wobbly torus a "cruller" here: https://arxiv.org/abs/1904.00076
https://en.wikipedia.org/wiki/Cruller#/media/File:French-Cruller-Donut.jpg

Cheers, Alex

@bobbielf2
Copy link
Owner

Hi Alex,
Thanks for testing the code! I just pushed a fix to the compatibility issue, let me know if they don't work.
I will update the preprint and mention the "cruller" for sure.
Thanks, Bobbie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants