Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query Avatax after orders are sent to ensure they actually arrived, record this somewhere, re-send if needed #182

Open
zachfeldman opened this issue Jun 13, 2023 · 9 comments

Comments

@zachfeldman
Copy link

We have a problem where something like 5 or 10% of orders a month do not make it in to Avalara and we have to manually send them over with avalara_capture and avalara_capture_finalize called on each instance to re-send. This is due to various issues, us being down, Avalara being down, validation issues with an order maybe (just a theory), etc. It seems the gem's sending is only best effort.

If there was a new column added for actually checking if an order made it over after transmission to the avalara_transaction table, something like a capturedboolean, and a Rake task you could run daily to check for orders that didn't make it and re-send them, that would be incredibly helpful.

I think we really have to check after sending with a subsequent API call looking for the order in Avalara and then mark captured as true only if we double checked with Avalara after the fact. We're going to have to build something like this ourselves in the next few months if it isn't a part of the lib.

Thanks for your consideration!

@zachfeldman
Copy link
Author

@kennyadsl here's the issue we discussed filing!

@dhonig
Copy link
Contributor

dhonig commented Jun 13, 2023 via email

@kennyadsl
Copy link
Collaborator

If this is something done after the order is finalized, what if we extract the API call in an ActiveJob class so that we can easily push that job to a retriable background queue?

@dhonig
Copy link
Contributor

dhonig commented Jun 13, 2023 via email

@zachfeldman
Copy link
Author

Whoops @kennyadsl I forgot your suggestion!

@dhonig that would also help a lot with this problem: running the API call in a retry-able task so we can actually ensure it succeeds, or at least tries again, would go a long way.

@dhonig
Copy link
Contributor

dhonig commented Jun 13, 2023 via email

@zachfeldman
Copy link
Author

@dhonig just checking in to see if there's any movement on this one? We continue to have to manually send orders every month that don't make it through. Appreciate you considering working on it!

@dhonig
Copy link
Contributor

dhonig commented Sep 11, 2023

@zachfeldman Can you elaborate more on 'manually send orders'. This should only happen if there is some other issue. If you can email me at [email protected] I can schedule sometime to consult with you ( likely next week.). Off the top of my had this sounds like its happening because of some other complication. Perhaps we can pool our heads together and see what needs to be done to resolve the issue.

@zachfeldman
Copy link
Author

Sure @dhonig just sent you an email to schedule some time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants