Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can I move the trigger icon for changing the theme #42

Open
hamishwillee opened this issue Sep 12, 2022 · 2 comments
Open

Can I move the trigger icon for changing the theme #42

hamishwillee opened this issue Sep 12, 2022 · 2 comments

Comments

@hamishwillee
Copy link

Thank you for the theme. I want to add the icon to the navbar, so I tried moving it as shown below. However it gets recreated somehow in the original position, with the result that there are now two icons, and neither can trigger.

Is there any way to move the icon safely?

         hook.doneEach(function() {
			const darkLightLink = document.querySelector("#docsify-darklight-theme");
			const fred = document.getElementsByClassName("app-nav")[0].appendChild(darkLightLink); //
			darkLightLink.style.display = 'inline-block';
			darkLightLink.style.position = 'relative';
			darkLightLink.style.top = '15px';
          });
@hamishwillee
Copy link
Author

Ignore that. I'll just rewrite the plugin to write to the app bar. Would be nice to have this as an option :-). Thanks again for your wonderful plugin.

@TotallyInformation
Copy link

I agree, the icon is in a strange place, it would be better to allow the parent selector to be set in config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants