Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using std::iterator as base class is deprecated in C++17, causes warnings in MSVC++ #20

Open
vbaderks opened this issue Jan 29, 2022 · 0 comments

Comments

@vbaderks
Copy link

The following code requires an explicit macro to suppress a warning to be defined when compiling with MSVC++:

class state_iterator : public std::iterator<

Adding _SILENCE_CXX17_ITERATOR_BASE_CLASS_DEPRECATION_WARNING solves the problem as a workaround. Other Boost libraries have fixed this issue in the past, for example: boostorg/utility#34

Can provide PR if needed.

Background info:
https://www.fluentcpp.com/2018/05/08/std-iterator-deprecated/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant