Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nav bar active links not marked properly #1200

Closed
rbbeeston opened this issue Aug 23, 2024 · 8 comments
Closed

Nav bar active links not marked properly #1200

rbbeeston opened this issue Aug 23, 2024 · 8 comments
Assignees
Labels
Bug Something isn't working Req. for Launch

Comments

@rbbeeston
Copy link
Member

No description provided.

@rbbeeston rbbeeston converted this from a draft issue Aug 23, 2024
@rbbeeston rbbeeston moved this from Todo to In Progress in website-v2 Aug 28, 2024
@rbbeeston rbbeeston assigned rbbeeston and unassigned rbbeeston Aug 28, 2024
@rbbeeston rbbeeston moved this from In Progress to Todo in website-v2 Aug 29, 2024
@daveoconnor daveoconnor moved this from Todo to In Progress in website-v2 Sep 19, 2024
@daveoconnor
Copy link
Collaborator

Image

Looks like it is being styled, it has the is-current-page is-active classes applied on the <li>, although the visual difference is very small. Do you want me to make it orange to match the active link in the header nav?

@vinniefalco
Copy link
Member

Are we talking about the table of contents on the left side?

@rbbeeston rbbeeston added the Bug Something isn't working label Sep 26, 2024
@daveoconnor
Copy link
Collaborator

@vinniefalco yes

@julioest
Copy link
Collaborator

julioest commented Sep 26, 2024

Do you want me to make it orange to match the active link in the header nav?

Hi @daveoconnor! Just a heads up, we decided earlier to manage this behavior through boostlook with a caret

Example:
image

@vinniefalco
Copy link
Member

What is this?
image

@julioest
Copy link
Collaborator

Hey @vinniefalco. That's the toc for the article itself

@vinniefalco
Copy link
Member

its ugly.. why is it there? Previously, this was a nifty control to the right. I prefer that, if it is going to be visible. However, one of the options is to disable that control, which I prefer even more over having it at all (for URL). If that option disables the control it should not be visible at the top of the page.

@julioest
Copy link
Collaborator

julioest commented Nov 8, 2024

✓ Fixed: Nav bar active state indicators working correctly.
TOC improvements moved to: boostorg/website-v2-docs#341

Closing.

@julioest julioest closed this as completed Nov 8, 2024
@github-project-automation github-project-automation bot moved this from Accepted to Done in website-v2 Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Req. for Launch
Projects
Status: Done
Development

No branches or pull requests

5 participants