Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type error in launch file #5

Open
Bhajneet-Singh-Bedi opened this issue Feb 9, 2024 · 1 comment
Open

Type error in launch file #5

Bhajneet-Singh-Bedi opened this issue Feb 9, 2024 · 1 comment

Comments

@Bhajneet-Singh-Bedi
Copy link

Bhajneet-Singh-Bedi commented Feb 9, 2024

for right camera
param name="frame_id" value="$(arg camera_name)left_optical_frame"
has to be changed to
param name="frame_id" value="$(arg camera_name)
right_optical_frame"

@borongyuan
Copy link
Owner

I haven't used this package in a while, so I may have forgotten some details. The images are already rectified before disparity is calculated. So they should have the same frame_id. I forgot at which step rectification is completed. But the rectification in ROS probably doesn’t use tf either. Strictly speaking, this may be an error. But if you add other frame_id, you may also need to add tf configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants