Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag preview icon should display under cursor (or at least close to it) #596

Closed
Skaiir opened this issue Apr 5, 2023 · 3 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@Skaiir
Copy link
Contributor

Skaiir commented Apr 5, 2023

Describe the Bug

Currently, the drag preview does not appear under the cursor, but displays offset relative to where it was grabbed from, which makes it a little clunky to drag around (it becomes uncertain whether to use the mouse or the preview as the drop target).

Where the preview appears when grabbed at the rightmost point (red star)
image

Steps to Reproduce

  1. add any field
  2. start dragging it from its rightmost point
  3. preview isn't under cursor, and remains offset until drop

Expected Behavior

  1. preview should remain under the mouse cursor
@Skaiir Skaiir added bug Something isn't working backlog Queued in backlog labels Apr 5, 2023
@Skaiir
Copy link
Contributor Author

Skaiir commented Apr 5, 2023

Seems there some discussion around this topic:

I think they key thing here is that the offset isn't configurable (yet). Something we could bring into our own dragula fork, and the dragula 2 in the future.

@pinussilvestrus
Copy link
Contributor

The maintainer of dragula@2 is currently working on exactly that: #588 (comment) 🎉

Skaiir added a commit that referenced this issue Feb 13, 2024
@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Feb 13, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the backlog Queued in backlog label Feb 13, 2024
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending in progress Currently worked on and removed in progress Currently worked on needs review Review pending labels Feb 13, 2024
Skaiir added a commit that referenced this issue Mar 7, 2024
Skaiir added a commit that referenced this issue Sep 13, 2024
@Skaiir Skaiir mentioned this issue Sep 13, 2024
Skaiir added a commit that referenced this issue Sep 13, 2024
Skaiir added a commit that referenced this issue Sep 13, 2024
Skaiir added a commit that referenced this issue Sep 13, 2024
Skaiir added a commit that referenced this issue Sep 13, 2024
Skaiir added a commit that referenced this issue Sep 13, 2024
Skaiir added a commit that referenced this issue Sep 13, 2024
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Sep 13, 2024
vsgoulart pushed a commit that referenced this issue Sep 13, 2024
vsgoulart pushed a commit that referenced this issue Sep 13, 2024
vsgoulart pushed a commit that referenced this issue Sep 13, 2024
@Skaiir
Copy link
Contributor Author

Skaiir commented Sep 13, 2024

Closed via #1267

@Skaiir Skaiir closed this as completed Sep 13, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

2 participants