Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should have a config variable to set minimum role allowed to access #1

Open
phpsa opened this issue May 2, 2018 · 1 comment
Open
Assignees

Comments

@phpsa
Copy link

phpsa commented May 2, 2018

Have content editors and normal admins would like to actually prevent them from impersonating - which i have done, but would suggest adding this as a config variable

@bpocallaghan
Copy link
Owner

Hi @phpsa
This is actually a good idea.
This might be a bit tricky, as I am sure everyone has their own roles/permissions setup.
Not sure if you perhaps have an idea that might work for you/others?

What I currently do is, I only add the impersonate button when the user have the relevant role.
I have a user_role many to many table. I then do something like $user->isAdmin() || $user->isEditor() - and then add the impersonate html. However I do understand its a bit tricky...

I am not sure if you use the starter project of mine or your own setup - as if you use the starter project - we can make it for it and if u need your own implementation - can do it the 'manual' route?

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants