From 0ad403a6e80fc69fc2cfe55bb8958c1b315f8182 Mon Sep 17 00:00:00 2001 From: Brandon Page Date: Fri, 1 Nov 2024 18:59:00 -0700 Subject: [PATCH] no message --- .github/DangerStaticAnalysis.rb | 4 ++-- .github/workflows/pr.yaml | 17 +++++++++-------- 2 files changed, 11 insertions(+), 10 deletions(-) diff --git a/.github/DangerStaticAnalysis.rb b/.github/DangerStaticAnalysis.rb index 7e9c927680..4a955c77a0 100644 --- a/.github/DangerStaticAnalysis.rb +++ b/.github/DangerStaticAnalysis.rb @@ -23,9 +23,9 @@ # Set Github Job output so we know which tests to run -File.write('../libs_to_run.txt', "libs=[#{modifed_libs.join(", ")}]") +# File.write('../libs_to_run.txt', "libs=[#{modifed_libs.join(", ")}]") # `echo "libs=[ #{modifed_libs.join(", ")} ]" >> "$GITHUB_OUTPUT"` -# ENV['GITHUB_OUTPUT'] = "libs=[ #{modifed_libs.join(", ")} ]" +ENV['GITHUB_OUTPUT'] = "libs=[#{modifed_libs.join(", ")}]" # files = Set[] # for lib in modifed_libs; diff --git a/.github/workflows/pr.yaml b/.github/workflows/pr.yaml index 63891ab1c3..f1743856fc 100644 --- a/.github/workflows/pr.yaml +++ b/.github/workflows/pr.yaml @@ -21,6 +21,7 @@ jobs: ./install.sh - name: Static Analysis and Danger if: ${{ github.event_name == 'pull_request' }} && (success() || failure()) + id: danger env: DANGER_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }} run: | @@ -29,20 +30,20 @@ jobs: cd .github bundle update && bundle install bundle exec danger --dangerfile=DangerStaticAnalysis.rb - - name: Test - run: cat libs_to_run.txt - - name: Set Libs Value - id: danger - run: echo "$(cat libs_to_run.txt)" >> $GITHUB_OUTPUT - - name: Test print - run: echo ${{ steps.danger.outputs.libs }} + # - name: Test + # run: cat libs_to_run.txt + # - name: Set Libs Value + # id: danger + # run: echo "$(cat libs_to_run.txt)" >> $GITHUB_OUTPUT + # - name: Test print + # run: echo ${{ steps.danger.outputs.libs }} ios-pr: needs: [static-analysis] strategy: fail-fast: false matrix: - lib: ${{ needs.static-analysis.outputs.libs }} + lib: ${{ fromJson(needs.static-analysis.outputs.libs) }} # lib: [SalesforceSDKCommon, SalesforceAnalytics, SalesforceSDKCore, SmartStore, MobileSync] uses: ./.github/workflows/reusable-workflow.yaml with: