New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

numPerInterval needs to be dynamic based on the the order creation request #1997

Open

husobee opened this issue Sep 19, 2023 · 1 comment

Assignees

Labels

skus

Contributor

husobee commented Sep 19, 2023

In the skus service

 func (s *Service) CreateOrderFromRequest(ctx context.Context, req model.CreateOrderRequest) (*Order, error) {

Currently has numPerInterval hard coded to 2, and this should be based on the order creation data instead.

husobee added P2 skus labels

husobee mentioned this issue

numPerInterval for Leo sku is 192, 2 is default #1998

Merged

18 tasks

Contributor

pavelbrm commented Sep 26, 2023

Maybe I could take a look at this as part of the current work, because I've seen it, and thought it was odd that it had been hard coded.

husobee assigned pavelbrm

husobee removed the P2 label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment