Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename challenge bypass kafka topics and fix local docker-compose environment #2249

Open
evq opened this issue Dec 12, 2023 · 0 comments
Open

Comments

@evq
Copy link
Contributor

evq commented Dec 12, 2023

currently we use the variables GRANT_CBP_SIGN_CONSUMER_TOPIC and GRANT_CBP_SIGN_PRODUCER_TOPIC. this naming is confusing as each kafka topic ( token sign requests, signed token results ) has both a producer and consumer and it is unclear from the name what the purpose of each topic is. ( e.g. are the roles referring to our perspective or the challenge bypass service's perspective? )

as a result of this poor naming, we have actually confused the two and our docker-compose.yml does not work properly end to end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant