Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent keyboard shortcut from closing pinned tabs #36283

Open
chrismore opened this issue Feb 21, 2024 · 0 comments
Open

Prevent keyboard shortcut from closing pinned tabs #36283

chrismore opened this issue Feb 21, 2024 · 0 comments
Labels
feature/keyboard-shortcuts feature/pinned-tabs feature-request needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include

Comments

@chrismore
Copy link
Collaborator

Description

Steps to Reproduce

  1. Open Brave desktop
  2. Open two tabs
  3. Pin one of the tabs
  4. Put focus on the pinned tab
  5. Use the close tab keyboard shortcut (command+W)

Actual result:

Pinned tab closes

Expected result:

Pinned tab does not close and focus is moved to the first open tab

Reproduces how often:

Always

Desktop Brave version:

All

Version/Channel Information:

All

Other Additional Information:

Competitive intel:

  • Chrome: Keyboard short cuts do close pinned tabs
  • Firefox and Arc: Keyboard shortcut does not close pinned tabs
@rebron rebron added the needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. label Feb 23, 2024
@rebron rebron moved this to Untriaged backlog in Front End May 28, 2024
@rebron rebron moved this from Untriaged backlog to On Deck in Front End Mar 5, 2025
@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include labels Mar 5, 2025
@rebron rebron changed the title Feature: Prevent keyboard shortcut from closing pinned tabs Prevent keyboard shortcut from closing pinned tabs Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature/keyboard-shortcuts feature/pinned-tabs feature-request needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include
Projects
Front End
Status: On Deck
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chrismore @bsclifton @rebron