Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] - Popup from Parent Tab shows on Child Tab #44061

Closed
3 of 5 tasks
Brandon-T opened this issue Feb 18, 2025 · 1 comment · Fixed by brave/brave-core#27708
Closed
3 of 5 tasks

[iOS] - Popup from Parent Tab shows on Child Tab #44061

Brandon-T opened this issue Feb 18, 2025 · 1 comment · Fixed by brave/brave-core#27708
Assignees
@Brandon-T
Labels
OS/iOS Fixes related to iOS browser functionality QA/Test-All-Platforms QA/Yes release-notes/include security
Milestone
1.76.x - Release

Comments

@Brandon-T
Copy link

Description

  • If you request permissions for something, and navigation fast enough to another tab, the permissions popup will show on the new tab.
  • It's not really a security flaw because we do show the origin on the popup, but it should be fixed.

Steps to reproduce

  1. https://hackerone.com/reports/2996498
  2. Follow-Up to: [iOS] - Dismiss alerts on navigation change brave-core#27179

Actual result

  • Popup from the parent tab shows on the child tab

Expected result

  • Popup should be dismissed when switching tabs

Reproduces how often

Easily reproduced

Brave version

  • Any

Device/iOS version

  • Any

Affected browser versions

  • latest AppStore
  • latest TestFlight
  • previous TestFlight

Reproducibility

  • with Brave Shields disabled
  • in the latest version of mobile Safari

Miscellaneous information

No response
@Brandon-T Brandon-T added OS/iOS Fixes related to iOS browser functionality QA/Yes release-notes/exclude labels Feb 18, 2025
@Brandon-T Brandon-T self-assigned this Feb 18, 2025
@Brandon-T Brandon-T mentioned this issue Feb 18, 2025
Merged
24 tasks
@brave-builds brave-builds added this to the 1.77.x - Nightly milestone Feb 21, 2025
@brave-builds brave-builds mentioned this issue Feb 27, 2025
Merged
7 tasks
@kjozwiak kjozwiak mentioned this issue Mar 5, 2025
Open
5 tasks
@kjozwiak
Copy link
Member

kjozwiak commented Mar 5, 2025

The above requires 1.76.73 or higher for 1.76.x verification 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Brandon-T Brandon-T

Labels
OS/iOS Fixes related to iOS browser functionality QA/Test-All-Platforms QA/Yes release-notes/include security
Projects
None yet
Milestone
1.76.x - Release
Development

Successfully merging a pull request may close this issue.

[iOS] - Parent Tab popups show on Child Tabs brave/brave-core
3 participants
@Brandon-T @kjozwiak @brave-builds