You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently we are using baseDomain: String? extension on URL when we intend to use the eTLD+1. This can cause issues when the computed property returns nil. This can happen with urls listed in effective_tld_names.dat, for example httpbin.org.
Steps to reproduce
User Agent:
Visit httpbin.org
Using Safari web inspector, check the value of navigator.userAgent. It should contain Mobile by default
Tap ... and tap Request Desktop Site (may be behind Show All).
Using Safari web inspector, check the value of navigator.userAgent.
Bug: still using Mobile user agent despite requesting desktop site.
Shred:
Visit httpbin.org
Tap ... and tap Shred Site Data (may be behind Show All).
In the confirmation alert, tap Shred Data
Bug: Site is not shred, tab remains open.
Actual result
User Agent:
Still uses Mobile user agent despite requesting desktop site.
Shred:
Site is not shred, tab remains open
Expected result
User Agent:
User agent correctly updates to desktop user agent.
Shred:
Site is shred, tabs closed
Reproduces how often
Easily reproduced
Brave version
Device/iOS version
Affected browser versions
latest AppStore
latest TestFlight
previous TestFlight
Reproducibility
with Brave Shields disabled
in the latest version of mobile Safari
Miscellaneous information
There's likely more cases where we expect baseDomain to be non-nil and it causes unintended issues like above with User Agent and Shred.
The text was updated successfully, but these errors were encountered:
Description
Currently we are using
baseDomain: String?
extension onURL
when we intend to use the eTLD+1. This can cause issues when the computed property returns nil. This can happen with urls listed in effective_tld_names.dat, for examplehttpbin.org
.Steps to reproduce
User Agent:
httpbin.org
navigator.userAgent
. It should containMobile
by default...
and tapRequest Desktop Site
(may be behindShow All
).navigator.userAgent
.Mobile
user agent despite requesting desktop site.Shred:
httpbin.org
...
and tapShred Site Data
(may be behindShow All
).Shred Data
Actual result
User Agent:
Mobile
user agent despite requesting desktop site.Shred:
Expected result
User Agent:
Shred:
Reproduces how often
Easily reproduced
Brave version
Device/iOS version
Affected browser versions
Reproducibility
Miscellaneous information
There's likely more cases where we expect
baseDomain
to be non-nil and it causes unintended issues like above with User Agent and Shred.The text was updated successfully, but these errors were encountered: