Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[unified-server] Unified server tests break global CI run #4249

Closed
timswanson-google opened this issue Jan 28, 2025 · 4 comments · Fixed by #4233
Closed

[unified-server] Unified server tests break global CI run #4249

timswanson-google opened this issue Jan 28, 2025 · 4 comments · Fixed by #4233

Comments

@timswanson-google
Copy link
Member

A PR that added the board server build into the dependency graph of broke CI runs because it caused the global test target to fail.

Original PR - #4145

Rollback PR - #4152

The problem seems to relate to the index.js file generated as part of the board server build being clobbered, since the build step is getting rerun concurrently.
timswanson-google added a commit that referenced this issue Jan 28, 2025
@timswanson-google
[unified-server] Build board server when building unified server
0cfaa2e 
This causes a test failure which demonstrates the issue referenced in #4249
@timswanson-google timswanson-google mentioned this issue Jan 28, 2025
Open
@timswanson-google
Copy link
Member Author

This issue can be seen in PR #4250, which is a minimal demonstration of the issue:

https://github.com/breadboard-ai/breadboard/actions/runs/13019338901/job/36316172993?pr=4250

@timswanson-google
Copy link
Member Author

@aomarks has submitted a change to wireit to improve the error messaging in cases like this:

google/wireit#1270

@timswanson-google
Copy link
Member Author

With the improved error messaging, the failed run now looks like this:

https://github.com/breadboard-ai/breadboard/actions/runs/13018501422/job/36313463374

❌ [packages/board-server:build:esbuild] Output file "/home/runner/work/breadboard/breadboard/packages/board-server/dist/server/index.js" was deleted unexpectedly. Is another process writing to the same location?

timswanson-google added a commit that referenced this issue Jan 28, 2025
@timswanson-google
[unified-server] Remove tests from global test run
8cdef03 
This works around the error seen in #4249 by removing the tests from the
CI run.

This is acceptable for now because the current unified server tests are
just dummies that "assert true" to verify that they are run. We should
add these tests back to the global run when #4249 is fixed.
@timswanson-google timswanson-google mentioned this issue Jan 28, 2025
Merged
timswanson-google added a commit that referenced this issue Jan 28, 2025
@timswanson-google
[unified-server] Remove tests from global test run (#4252)
d7ecbb2 
This works around the error seen in #4249 by removing the tests from the
CI run.

This is acceptable for now because the current unified server tests are
just dummies that "assert true" to verify that they are run. We should
add these tests back to the global run when #4249 is fixed.
@timswanson-google
Copy link
Member Author

timswanson-google commented Jan 28, 2025 •
edited
Loading

For now, this issue has been worked around by removing the unified server test from the global test run. We should add it back once we root cause this issue and figure out how to address it.

@aomarks aomarks mentioned this issue Jan 28, 2025
Merged
aomarks added a commit that referenced this issue Jan 28, 2025
@aomarks
Add a couple of missing wireit dependency graph edges (#4253)
1c7186b 
Doesn't directly address
#4249, but should fix
the failure from
https://github.com/breadboard-ai/breadboard/actions/runs/13021227644/job/36322130934

```
src/example-board-server.ts:25:30 - error TS2307: Cannot find module '@breadboard-ai/example-boards/playground-boards.json' or its corresponding type declarations.

25 import playgroundBoards from "@breadboard-ai/example-boards/playground-boards.json" assert { type: "json" };
```

cc @timswanson-google
@aomarks aomarks mentioned this issue Jan 29, 2025
Merged
aomarks added a commit that referenced this issue Jan 29, 2025
@aomarks
[board-server] [unified-server] Fix output clobbering bug (#4233)
375c8a9 
Should fix #4249

The `build:tests` and `build:esbuild` scripts in the `board-server`
package were both writing to the same place (`dist/`), with each
deleting the output of the other (in the case of `build:tests`, deleting
the whole `dist/` folder).

google/wireit#65 is a long-standing feature
request for wireit that would let us detect cases like this
automatically
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[board-server] [unified-server] Fix output clobbering bug breadboard-ai/breadboard
1 participant
@timswanson-google